Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the version checks to changelog tasks #1019

Merged
merged 8 commits into from
Oct 11, 2024
Merged

Conversation

pomek
Copy link
Member

@pomek pomek commented Oct 7, 2024

Suggested merge commit message (convention)

Feature (ci): Created a new binary script called ckeditor5-dev-ci-is-workflow-restarted that returns with a non-zero exit code if a given workflow is executed for the first time. The restarted workflows exit with a zero exit code.

Feature (release-tools): A user-provided version will be checked against npm availability while generating a changelog. If it is already taken, the tools will not allow it to be used.

Other (release-tools): The updateVersions() task will no longer verify if the specified version is available on npm.

Other (release-tools): The publishPackages() task filters out already published packages to avoid pushing the same archive twice. Thanks to that, it can be a part of a process that would be restarted.

Other (release-tools): The publishPackages() task tries to publish the package once again when it fails independently from the returned error code. Previously, it was scheduled only when the E409 error occurred.

Other (release-tools): The verifyPackagesPublishedCorrectly() task is no longer available as its responsibility has been merged into the publishPackages() task.

Other (release-tools): The commitAndTag() task does not commit files if a tag for the specified version is already created.


Closes cksource/ckeditor5-internal#3828.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

coveralls commented Oct 7, 2024

Coverage Status

coverage: 88.452% (-0.08%) from 88.531%
when pulling 7105a19 on i/3828-restartable-release
into a155390 on master.

@pomek pomek force-pushed the i/3828-restartable-release branch from fccb8bf to 390762f Compare October 8, 2024 05:47
@pomek pomek force-pushed the i/3828-restartable-release branch from 390762f to 6e47a6d Compare October 8, 2024 06:47
@pomek pomek marked this pull request as ready for review October 8, 2024 10:01
pomek added a commit to ckeditor/ckeditor5-react that referenced this pull request Oct 9, 2024
pomek added a commit to ckeditor/ckeditor5-angular that referenced this pull request Oct 9, 2024
pomek added a commit to ckeditor/ckeditor5-vue that referenced this pull request Oct 9, 2024
pomek added a commit to ckeditor/ckeditor5-integrations-common that referenced this pull request Oct 9, 2024
pomek added a commit to ckeditor/ckeditor5-linters-config that referenced this pull request Oct 9, 2024
pomek added a commit to ckeditor/ckeditor5 that referenced this pull request Oct 9, 2024
@pomek pomek requested review from psmyrek and martnpaneq October 9, 2024 12:31
psmyrek
psmyrek previously approved these changes Oct 10, 2024
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@pomek pomek merged commit ff7d738 into master Oct 11, 2024
6 of 7 checks passed
pomek added a commit to ckeditor/ckeditor5-react that referenced this pull request Oct 11, 2024
Internal: Aligned release scripts to recent changes in ckeditor5-dev (ckeditor/ckeditor5-dev#1019).
@pomek pomek deleted the i/3828-restartable-release branch October 11, 2024 04:52
pomek added a commit to ckeditor/ckeditor5-angular that referenced this pull request Oct 11, 2024
Internal: Aligned release scripts to recent changes in ckeditor5-dev (ckeditor/ckeditor5-dev#1019).
pomek added a commit to ckeditor/ckeditor5-vue that referenced this pull request Oct 11, 2024
Internal: Aligned release scripts to recent changes in ckeditor5-dev (ckeditor/ckeditor5-dev#1019).
pomek added a commit to ckeditor/ckeditor5-linters-config that referenced this pull request Oct 11, 2024
Internal: Aligned release scripts to recent changes in ckeditor5-dev (ckeditor/ckeditor5-dev#1019).
pomek added a commit to ckeditor/ckeditor5-integrations-common that referenced this pull request Oct 11, 2024
Internal: Aligned release scripts to recent changes in ckeditor5-dev (ckeditor/ckeditor5-dev#1019).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants